Attention is currently required from: arehbein, pespin, daniel.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/33084 )
Change subject: osmo_io: Fix sending msgb structures
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS2:
> Ok then I'll prepare a patch removing osmo_iofd_write_{en,dis}able
>
> Those were only ever intended as public API for the user. Internally the
> txqueue will take care of dis-/enabling the writes.
great. Then let's not introduce API where we don't have a clear use case for.
IF it should ever be needed, we can introduce it then.
> The next question then is whether read_{en,dis}able is actually needed in
> osmo_io.
I'd treat it like above, i.e. not introduce it now if we have no user in our
existing codebase, and introduce it _if_ ever needed later.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33084
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie2a9c93f820fa372a1d527c805fd0fe2cff0eb49
Gerrit-Change-Number: 33084
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Wed, 07 Jun 2023 10:05:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: daniel <[email protected]>
Gerrit-MessageType: comment
