Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 )
Change subject: cfg: add 'hnbgw' / 'plmn MCC MNC' ...................................................................... Patch Set 4: (2 comments) File src/osmo-hnbgw/hnbgw_l3.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178/comment/30213fcc_03b4753f PS3, Line 276: /* The user has not configured a PLMN, gues from the InitialUE message's LAI IE's PLMN */ > guess Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178/comment/070ab3dd_c32d6af2 PS3, Line 281: osmo_plmn_from_bcd(ies->lai.pLMNidentity.buf, &local_plmn); > maybe adding a log line here to let the user know we are deciding PLMN on our > own here. a log line here would say something like Using local PLMN as indicated in RANAP InitialUE message: 001-01 and the other if-branch would say Using local PLMN from cfg file: 001-01 Is that what you have in mind? In general, it would be good if you could give a very specific example of what you would insert, so we don't need to ping pong on the details. BTW another idea would be to compare the InitialUE PLMNs (there are something like four of them in there) with the PLMN from the cfg file, but i was too busy for that yet. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If404c3859acdfba274c719c7cb7d16f97d831a2a Gerrit-Change-Number: 33178 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 01:04:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
