Attention is currently required from: fixeria, pespin, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33083 )
Change subject: gsm/ipa: Add segmentation callback ...................................................................... Patch Set 6: (2 comments) File src/gsm/ipa.c: https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/f4ea7d54_1fcfe8c4 PS2, Line 730: msg->data_len < total_len > This (is supposed to) check the case where the msgb is not large enough to > contain a complete messag […] Seems better to me, as that would prevent more error cases File src/gsm/ipa.c: https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/5774f60e_8acd6911 PS5, Line 722: int ipa_segmentation_cb(struct msgb *msg) > This definetly requires documentation on params, return code, behavior, etc. Semantics are explained in change I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377, I could add -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Gerrit-Change-Number: 33083 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: daniel <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Thu, 08 Jun 2023 13:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
