Patch Set 5: IMO Max's comments do not hold.
However, this patch *does* make CTRL input parsing stricter and, I don't know of any, but this might break sloppy CTRL interface clients. E.g. trailing spaces or characters after a GET <id> <var> lead to a parsing error; before, we ignored any data following the cmds. -- To view, visit https://gerrit.osmocom.org/5438 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96a9b6b6a3a5e0b80513aa9eaa727ae8c9c7d7a1 Gerrit-PatchSet: 5 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
