Attention is currently required from: osmith, Hoernchen, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/simtrace2/+/32728 )
Change subject: contrib/jenkins: tweak shell logic
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS1:
> (oh I thought CR -1 was for patchset 2 ... […]
("==" looks wrong "[" is test, and in man test one can see that "=" should be
used to compare strings. Maybe test accepts both...)
Patchset:
PS2:
This is far better to read. As far as I can see it should be correct, however I
didn't verify it locally but I am sure you did that.
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/32728
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Id768e0dbed9265f042b942e6699683723ca40a7c
Gerrit-Change-Number: 32728
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 09 Jun 2023 10:51:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: Hoernchen <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment
