Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33301 )
Change subject: Add VGCS UPLINK GRAND message structure to gsm_04_08.h ...................................................................... Patch Set 1: (6 comments) File include/osmocom/gsm/protocol/gsm_04_08.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/9c6d0fbe_70580ac9 PS1, Line 1207: struct gsm48_hdr hdr; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/9c6959e4_8dbbc282 PS1, Line 1207: struct gsm48_hdr hdr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/778517f4_675c6891 PS1, Line 1208: struct gsm48_req_ref req_ref; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/d09e82c3_b0b2bf26 PS1, Line 1208: struct gsm48_req_ref req_ref; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/f1675fa2_94d68b3c PS1, Line 1209: uint8_t ta; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8251): https://gerrit.osmocom.org/c/libosmocore/+/33301/comment/03e48773_639d6370 PS1, Line 1209: uint8_t ta; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8a16ce4ddc7a36e0db2936227a910b4d53cddfca Gerrit-Change-Number: 33301 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 13 Jun 2023 13:23:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
