Attention is currently required from: arehbein, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31534 )
Change subject: common: Make socket queue max. length configurable ...................................................................... Patch Set 15: (1 comment) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/319cb465_3f6845ea PS9, Line 473: vty_out(vty, " pcu-socket-wqueue-length %d%s", bts->pcu.sock_wqueue_len_max, VTY_NEWLINE); > Odd, that should give a warning during compilation: sock_wqueue_len_max is > declared as unsigned int […] I agree with max. It is an unsigned int, so %d should cause a compiler warning. Not sure why it doesn't happen, but in any case printing unsinged as signed is not correct. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa Gerrit-Change-Number: 31534 Gerrit-PatchSet: 15 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: msuraev <[email protected]> Gerrit-Attention: arehbein <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Tue, 13 Jun 2023 14:47:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
