Patch Set 1: Code-Review-1 (3 comments)
https://gerrit.osmocom.org/#/c/5492/1/osmopy/__init__.py File osmopy/__init__.py: Line 2: __version__ = '0.0.5' Please bump the version to avoid confusion https://gerrit.osmocom.org/#/c/5492/1/osmopy/osmo_interact/ctrl.py File osmopy/osmo_interact/ctrl.py: Line 101: def main_verify_transcript_ctrl(): Why this is here and not in actual script? https://gerrit.osmocom.org/#/c/5492/1/scripts/osmo_interact_ctrl.py File scripts/osmo_interact_ctrl.py: Line 23: main_interact_ctrl() Why not just use the function body directly? Is it used someplace else as well? -- To view, visit https://gerrit.osmocom.org/5492 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40a37b212274cb70ebb1e1d9d1b3743eb2d64d05 Gerrit-PatchSet: 1 Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
