Attention is currently required from: osmith, dexter.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/33304 )

Change subject: mgcp_client: Introduce mgcp_client_conf_alloc(), deprecate 
mgcp_client_conf_init()
......................................................................


Patch Set 4: Code-Review+2

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/33304/comment/c24ce090_6d23a42f
PS3, Line 33: et
> let
Done


File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/33304/comment/39bf6bc5_5446f133
PS3, Line 211:  *  \param[out] ctx talloc context to use as a parent during 
allocation.
> I think this should be \param[in] ...
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33304
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iba0853ed099a32cf1dde78c17e1b34343db41cfc
Gerrit-Change-Number: 33304
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 14 Jun 2023 09:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment

Reply via email to