Attention is currently required from: osmith, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 )
Change subject: mgwpool: Document keepalive feature ...................................................................... Patch Set 1: (1 comment) File common/chapters/mgwpool.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/069d22e2_9c279813 PS1, Line 211: NOTE: The `keepalive` feature is disabled by default, and must be explicitly configured in order to enable it. > (just curious, not related to review) why? Because older osmo-mgw versions don't support the "null" endpoint, and they should be configured explicitly using any specific endpoint in order to avoid errors showing up in the log file (the keepalive mechansim would work fine still though). I'd enable it by default after next osmocom CNI release. This way also we leave users willing it to test it further meanwhile, while not forcing it on everybody for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a Gerrit-Change-Number: 33310 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
