Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33097 )
Change subject: Port to new libosmogsm 'struct osmo_sub_auth_data2' ...................................................................... Patch Set 3: (2 comments) File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/0564550d_683f2ba2 PS3, Line 10: libosmogsm UPDATE_DEP_VER update libosmogsm version dependency after Ie775fedba4a3fa12314c0f7c8a369662ef6a40df is released > fyi libosmogsm > 1.8. […] it didn't occur to me, thanks. File src/auc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/635a85b4_3e4341c8 PS3, Line 119: vec[i].res_len = 8; > maybe add a NOTICE log message if res_len was not 8, not let the user note > that this is missing prop […] I don't really get the comment. The old code never generated any res length != 8, so all this code is doing is enforcing the same behavior as before. Before this line, vec[i].res_len may not be initialized as it is the output variable passed by the function caller. It might be zero-initialized or contain random data. We need to set it to a supported value of libosmocore before calling osmo_auth_gen_vec*2 below. And in ordre to get the old behavior, we must set it to 8. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3207c7bfb73e9ff5471e5c26b66639549e4d48a2 Gerrit-Change-Number: 33097 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 14:59:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
