Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33312 )
Change subject: mgw: Allow auditing speciall 'null' endpoint ...................................................................... Patch Set 3: (1 comment) File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33312/comment/61ed9bf5_afa826c4 PS2, Line 473: > one option might be to turn the null endpoint into a real endpoint, one that > just drops all data it […] The main discussion to start with would be: Do we still want the null endpoint to be per-trunk? That would mean it ends up like "rtpbridge/null@mgw", instead of "null@mgw" we have now. This means we would have a trunk pointer available in the handlers, which may be handy and maybe allow having less specific code paths. On the other hand, that means the user has to figure out which trunk to use. Regarding acceptance of any data: That would mean we need to still create a separate endpoint object internally in osmo-mgw. Since we don't really need that right now, I really preferred skipping it since it may take some effort, since special cases may need to be checked all along where "endp" objects are being used. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia409b16e9211e6261e2e0f21288544289d6f3733 Gerrit-Change-Number: 33312 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 15 Jun 2023 15:25:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
