Attention is currently required from: laforge, daniel.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/33333 )

Change subject: socket: Ensure fd is not negative in osmo_sock_get_name_buf()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/core/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/33333/comment/60840c95_a006797d 
PS1, Line 1553: fd < 0
Use `OSMO_UNLIKELY` here maybe?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33333
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I76727993224ef87b475c33360c24966e82e866ec
Gerrit-Change-Number: 33333
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Fri, 16 Jun 2023 15:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to