Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33341 )
Change subject: osmo_io: Make name optional, add _set_name() API ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I think the ability to change it is definitely good. […] in the end is not making the implementation more complex though (just 2 extra checks) and it spares checking the input of set_name(), so all in all it's the same while allowing NULL cases being passed instead of erroring, which makes the API less prone to errors. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If2772a3ccaa98616e0189862a49ab0243435e343 Gerrit-Change-Number: 33341 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 19 Jun 2023 08:58:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
