pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/33373 )
Change subject: pdch.cpp: Drop impossible code path
......................................................................
pdch.cpp: Drop impossible code path
In that code path, new_tbf is an UPLINK_TBF. Uplink TBFs (tbf_ul_fsm.c)
don't use state TBF_ST_WAIT_RELEASE, hence that condition cannot ever be
true.
Change-Id: I379d4140326a46e94914152fe9b735de852ceda0
---
M src/pdch.cpp
1 file changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/73/33373/1
diff --git a/src/pdch.cpp b/src/pdch.cpp
index f871d1d..8a2ad96 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -401,9 +401,6 @@
"TBF is gone TLLI=0x%08x\n", tlli);
return;
}
- if (tbf->state_is(TBF_ST_WAIT_RELEASE) &&
- tbf->direction == new_tbf->direction)
- tbf_free(tbf);
osmo_fsm_inst_dispatch(new_tbf->state_fi,
TBF_EV_ASSIGN_ACK_PACCH, NULL);
/* there might be LLC packets waiting in the queue, but the DL
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33373
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I379d4140326a46e94914152fe9b735de852ceda0
Gerrit-Change-Number: 33373
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-MessageType: newchange
