Attention is currently required from: osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/33365 )

Change subject: transaction: move cc.codecs.remote -> cc.remote
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
Opening the debate here after looking at the whole patchset (I have no opinion 
but I think it's worth asking): Does it make sense to have the CSD modes 
separate from the audio_codecs? Cannot they be integrated into audio_codecs? In 
the end wouldn't it be something like AMR where you have several subtypes?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33365
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I5d2e078db3b3437cb6feae40d8955912d7a297e4
Gerrit-Change-Number: 33365
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Mon, 19 Jun 2023 17:19:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to