Attention is currently required from: pespin, fixeria.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/33083 )

Change subject: gsm/ipa: Add segmentation callback
......................................................................


Patch Set 11:

(2 comments)

File src/gsm/ipa.c:

https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/cae5ca89_0b9e6af0
PS8, Line 728:  *                       -EIO,    if the header declares a 
payload too large */
> There's no specific stone-written rule anywhere I'm aware of, and both are 
> accepted. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/cd815f7b_b0473545
PS8, Line 729: int ipa_segmentation_cb(struct msgb *msg)
> I was just sharing it here to make it easy for others (and myself) while 
> reviewing, since this funct […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33083
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f
Gerrit-Change-Number: 33083
Gerrit-PatchSet: 11
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 19 Jun 2023 18:30:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to