Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33369 )
Change subject: Add initial CSD support with external MNCC ...................................................................... Patch Set 2: (1 comment) File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/1f1a4989_e92a9b28 PS1, Line 113: struct csd_filter csd; This doesn't sound right to me, since the "audio" codec is always CLEARMODE:8000 for CSD. The bearer services aren't audio codecs or part of it, they are a combination of data rates, sync/asnc, transparent/non-transparent and rate adaption. I think in theory union made sense here, but it doesn't work since we also need to set the audio codec to clearmode (the fake audio codec that was invented for CSD). > I'm not saying it should be done that way, just raising concerns. Sure, and thanks for that! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ide8b8321e0401dcbe35da2ec9cee0abca821d99a Gerrit-Change-Number: 33369 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 20 Jun 2023 11:40:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
