Attention is currently required from: laforge, pespin, msuraev.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273 )

Change subject: add static SS7 routing example to cs7-config.adoc
......................................................................


Patch Set 2:

(8 comments)

File common/chapters/cs7-config.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/2324a0d4_01e497a7
PS1, Line 349: Osmocom SS7 supports dynamic routing, allowing minimal SS7 
configuration. If all of your components support dynamic
> I'd do a s/dynamic routing/dynamic routing key management/ all over the text. 
> […]
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/12b6141b_84091299
PS1, Line 373: - its own point-code -- has to match the PC in osmo-stp.cfg
> Perhaps better: "has to match its own PC entry in osmo-stp. […]
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/b5352d4a_92beba60
PS1, Line 376: - local+remote IP:port for M3UA -- have to match the IP:ports in 
osmo-stp.cfg
> IP:ports -> IP:port?
it's remote and local, two ports...


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/50688bf4_e4510244
PS1, Line 382: - local+remote IP:port for M3UA -- have to match the IP:ports in 
osmo-stp.cfg
> IP:ports -> IP:port?
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/baa9bbe6_16059873
PS1, Line 387: - all point-codes -- they have to match the PC in osmo-bsc.cfg 
and osmo-msc.cfg
> You list first point codes and afterwards routing keys in the MSC and BSC 
> section. […]
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/f2754bb7_974f1f0d
PS1, Line 388: - local+remote IP:port for M3UA -- have to match the IP:ports in 
osmo-bsc.cfg and osmo-msc.cfg
> IP:ports -> IP:port?
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/5f6c9192_311153e4
PS1, Line 454: ty synchronize point-codes and routing keys between STP and 
\{BSC,MSC}:
> typo: to
Done


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/88575ba9_99725ace
PS1, Line 454: synchronize
> I would replace synchronize with "manually configure", as "synchronize" might 
> refer to some kind of  […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I44afddf7004f5bf37eec706ca3da12c04f83f8fa
Gerrit-Change-Number: 32273
Gerrit-PatchSet: 2
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: msuraev <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: msuraev <[email protected]>
Gerrit-Comment-Date: Thu, 22 Jun 2023 14:59:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: msuraev <[email protected]>
Gerrit-MessageType: comment

Reply via email to