Attention is currently required from: pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/33457 )

Change subject: osmo-bts-sysmo: mute PHY until OML is ready
......................................................................


Patch Set 4:

(1 comment)

File src/osmo-bts-sysmo/l1_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/b45a9cfa_efca9a98
PS3, Line 1264:                         if (!trx->mo.opstart_success)
> > trx_rf_lock does not set BTS_STATUS_RF_ACTIVE, only BTS_STATUS_RF_MUTE (see 
> > mute_rf_compl_cb). […]
BTS_STATUS_RF_ACTIVE must be set, otherwise the LED stays off. See 
implementation of bts_update_status.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3
Gerrit-Change-Number: 33457
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 26 Jun 2023 15:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to