Attention is currently required from: laforge, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/33518 )

Change subject: vty: Improve output of show cs7 instance <0-15> asp
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-sccp/+/33518/comment/6b3ff3c9_1a614d90
PS2, Line 8:
Noting that Role and SCTP Role are now printed would be useful here


File src/osmo_ss7_vty.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/33518/comment/a39864d2_475ca2e9
PS2, Line 828: Remote IP Addr:Rmt Port
it might be useful to shorten this while at it, to "Remote IP:Port"?



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33518
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Id22bd4e74fb6f79950adba58862d379203d36760
Gerrit-Change-Number: 33518
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 27 Jun 2023 12:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to