Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33522 )
Change subject: pcu_sock: use PCUIF version 11 (direct TLLI) ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/33522/comment/b893c546_6510e477 PS1, Line 635: pcu_prim->u.data_cnf_dt = (struct gsm_pcu_if_data_cnf_dt) { iiuc this makes osmo-bts defacto only use the new SAPI, and hence only work properly against an osmo-pcu using/supporting PCUIF 11. IMHO, osmo-bts should store info on which SAPI was used to send the PDH_DATA.req and then use thew old or new SAPI based on that, to stay compatible against older osmo-pcu. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I25816ac12e63cc6b641eb414e6bc7eaa9c85fc25 Gerrit-Change-Number: 33522 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 27 Jun 2023 14:58:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
