Attention is currently required from: pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/33468 )

Change subject: mgcp-client: Mark client as UP when keepalive 
request-interval/timeout is disabled through VTY
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/33468/comment/c2aeb35c_30dcd32b
PS1, Line 12:
Add Fixes:...?


File src/libosmo-mgcp-client/mgcp_client_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/33468/comment/4f2704ef_9258eafc
PS1, Line 388:  } /* else: wait until connect() to do first scheduling */
maybe move the whole block into a new function to de-duplicate code? but not 
that important



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33468
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I263d23885a1a967f844033f9810b96691b8e3b30
Gerrit-Change-Number: 33468
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 27 Jun 2023 15:23:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to