Patch Set 1: Code-Review+2 I would argue that the TLLI might make more sense. The SCCP Connection IDentifier is a value that has local significance only (i.e. only between the SCCP provider (libosmo-sigtran) and the SCCP user (osmo-sgsn). The TLLI however is an address that shows up in protocol traces so it has some external significance, too. The main problem is probably that the TLLI changes over time :/
What makes most sense is to have some kind of lookup helper for rate counters in the SGSN where one could say "give me the counter for IMSI XYZ or PDO-Context 1 at IMSI XYZ". So the index is still there, but unused and replaced by a more meaningful way to query those counters that one is actually interested in. -- To view, visit https://gerrit.osmocom.org/5523 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1062ffdcac96c82269cab6f4e7ae50e28dc3aa44 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
