Attention is currently required from: laforge.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/33532 )
Change subject: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
This would only allow cells in the DCS range to refer to cells with PCS
frequencies. This makes no sense, because you cannot have DCS and PCS cells
mixed in the same network.
We want non DCS/PCS cells refer to DCS or PCS depending on the band indicator
when they talk about ARFCN 512..885.
The actual fix must be done in several locations at
layer23/src/mobile/gsm48_rr.c:
if (gsm_refer_pcs(CELL-ARFCN, s) && REFER-ARFCN >= 512 && REFER-ARFCN <= 810)
REFER-ARFCN |= ARFCN_PCS;
Where CELL-ARFCN is the frequency of the cell and REFER-ARFCN is a frequency
the cell talks about.
File src/host/layer23/src/common/sysinfo.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33532/comment/ee7545ef_f64fb346
PS2, Line 65: (arfcn >= 512 && arfcn <= 810)
This would only allow cells in the DCS range to refer to cells with PCS
frequencies. This makes no sense, because you cannot have DCS and PCS cells
mixed in the same network.
We want non DCS/PCS cells refer to DCS or PCS depending on the band indicator
when they talk about ARFCN 512..885.
The actual fix must be done in several locations at
layer23/src/mobile/gsm48_rr.c:
if (gsm_refer_pcs(CELL-ARFCN, s) && REFER-ARFCN >= 512 && REFER-ARFCN <= 810)
REFER-ARFCN |= ARFCN_PCS;
Where CELL-ARFCN is the frequency of the cell and REFER-ARFCN is a frequency
the cell talks about.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33532
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007
Gerrit-Change-Number: 33532
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 29 Jun 2023 08:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
