Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33525 )
Change subject: Re-store last LLC frames never completely acked when freeing DL TBF ...................................................................... Patch Set 2: (2 comments) File src/llc.c: https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/4efed514_77842342 PS2, Line 368: OSMO_ASSERT(info); > maybe add a comment on top of the function that the queue must not be empty > if out_info is set? If the queue is empty, msg=NULL and return in line 362 occurs, so this case you say cannot happen. File src/tbf_dl.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/6ea3ec69_c7f9e926 PS2, Line 546: if any > might be a bit nitpicky, but the "if any" part is dealt with above; now the > function will assert if […] See my other comment, function doesn't assert. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9be4035fb2cf2b3ee56e91dcc12cc8c24028b4aa Gerrit-Change-Number: 33525 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Thu, 29 Jun 2023 12:52:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
