Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/5498/1/include/osmocom/ranap/iu_helpers.h File include/osmocom/ranap/iu_helpers.h: Line 11: int ranap_transp_assoc_decode(uint16_t *port, RANAP_IuTransportAssociation_t *transp_assoc); input pointer arguments should be 'const' https://gerrit.osmocom.org/#/c/5498/1/src/iu_helpers.c File src/iu_helpers.c: Line 113: snprintf(addr, addr_len, "%u.%u.%u.%u", buf[3], buf[4], buf[5], buf[6]); can we please simply use inet_ntop() to do the conversion? I don't see reasons to re-invent standard C library functions here. This way the function could even do IPv6 from day one (even though if higher layers don't). If you explicitly don't want IPv6, you could still use inet_ntoa(). -- To view, visit https://gerrit.osmocom.org/5498 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1a0455c5f25cae41ee19229d6daf299e023062 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
