Patch Set 1: Code-Review-1 (3 comments)
https://gerrit.osmocom.org/#/c/5499/1/src/ranap_msg_factory.c File src/ranap_msg_factory.c: Line 253: LOGP(DRANAP, LOGL_ERROR, "error encoding security mode command IEs: %d\n", rc); ASN_SEQUENCE_ADD() might do a realloc() inside asn_set_add() so please make sure you do proper cleanup. In fact, the ASN_STRUCT_FREE_CONTENTS_ONLY exactly below this statement are doing this ,so the if-then-return clause you add should be after those two calls but before ranap_generate_initiating_message() Line 332: if (rc < 0) { same problem ehre, move this below the ASN_STRUCT_FREE_CONTENTS_ONLY() but above the ranap_generate_* Line 458: if (rc < 0) { and once more. -- To view, visit https://gerrit.osmocom.org/5499 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I592c0794a94c50fde5c574b1e9bc581eb28af4ae Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
