Attention is currently required from: arehbein, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 )
Change subject: stream: Add server-side (segmentation) support for IPAC ...................................................................... Patch Set 5: Code-Review-1 (1 comment) Patchset: PS5: IIUC, the only that actually matters here for the user of the osmo_stream is adding a specific segmentation callback specific to IPAC. So I'd really avoid adding IPAC specific information in osmo_stream, and simply add a set_segmentation_callback() where the user wishing to establish an IPA stream can pass the relevant callback. And tbh, I'm not even sure why this segmentation callback needs to be done in osmo_stream, to me it belongs to a layer on top of it. I'm happy to discuss or be convinced otherwise. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c Gerrit-Change-Number: 33197 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: arehbein <arehb...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Fri, 30 Jun 2023 13:38:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
