fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/33564 )
Change subject: lu_fsm: fix memleak in lu_fsm_wait_insert_data_result()
......................................................................
lu_fsm: fix memleak in lu_fsm_wait_insert_data_result()
Currently osmo-hlr leaks memory (msgb holding 1203 bytes of data and
a struct osmo_gsup_req) on receipt of OSMO_GSUP_MSGT_INSERT_DATA_ERROR.
Change-Id: I4c70a06169158c869360707a7a62436dbf13b9b3
---
M src/lu_fsm.c
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
dexter: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/src/lu_fsm.c b/src/lu_fsm.c
index e6ed31a..8599f59 100644
--- a/src/lu_fsm.c
+++ b/src/lu_fsm.c
@@ -275,6 +275,7 @@
case OSMO_GSUP_MSGT_INSERT_DATA_ERROR:
lu_failure(lu, GMM_CAUSE_NET_FAIL, "Rx %s",
osmo_gsup_message_type_name(req->gsup.message_type));
+ osmo_gsup_req_free(req);
break;
default:
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33564
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I4c70a06169158c869360707a7a62436dbf13b9b3
Gerrit-Change-Number: 33564
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-MessageType: merged
