Attention is currently required from: jolly, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/33548 )

Change subject: ASCI: Support conference briding with 1..n connections
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
> My idea was to use pointers to increase performance. […]
mh. but don't we have a per-endpoint list of connections? so we would only be 
"iterating" a linked list of two entries in the  "most cases" scenario you 
described above?  Do you really think that iterating a list with two entries 
(whcih is three dereferences of the next pointer) is significantly slower than 
the mechanism you're introducing?  I'm somewhat doubtful we should have that 
level of complexity without knowing for sure that there's an actual performance 
issue to begin with.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33548
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic99a55ab5a3a6170e940403fadd52697e99f2f3a
Gerrit-Change-Number: 33548
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 05 Jul 2023 11:41:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to