Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33596 )
Change subject: ASCI: Add new rate counters to support VGCS/VBS messages ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Another case of "first adding definitions in one patch and then using them in some other patch". Let's please add the definition in the same patch where they are used, to avoid ending with dangling counters not ticked, either now or upon revert, backport, etc. File src/osmo-bsc/osmo_bsc_msc.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33596/comment/f82a7c3b_418b28ae PS1, Line 149: [MSC_CTR_BSSMAP_TX_DT1_VGCS_VBS_SETUP_ACK] = { Same, format change. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18e4ca3599e480de2d0f64cc1b6f4bb6ce8020d4 Gerrit-Change-Number: 33596 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Fri, 07 Jul 2023 11:45:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
