Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/33606 )

Change subject: ASCI: Do not wait for RLL establishment
......................................................................


Patch Set 2:

(2 comments)

File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/33606/comment/f412a3e0_379caa34
PS2, Line 1046:           || lchan->activate.info.activ_for == 
ACTIVATE_FOR_VGCS_CHANNEL) && !requires_rtp_stream) {
wrong indentation. Also, you can move the 3rd cndition to a new line too.


https://gerrit.osmocom.org/c/osmo-bsc/+/33606/comment/31c907bc_c7ab1e11
PS2, Line 1070:                 if (lchan->sapis[0] != LCHAN_SAPI_UNUSED || 
lchan->activate.info.activ_for == ACTIVATE_FOR_VGCS_CHANNEL)
it would be clearer moving the new extra condition to a new line.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33606
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I96390924736029b92e54590157e38093be749dd9
Gerrit-Change-Number: 33606
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Fri, 07 Jul 2023 11:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to