Attention is currently required from: tnt. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33641 )
Change subject: gsm: Improve the TCH/H2.4 coding routines ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Patchset: PS2: > FWIW I don't agree with the linter. […] We can remove the V-1 vote and re-add V+1 manually, if others find it more readable. Personally I don't have a strong preference here and for me it's fine either way. This is also an option, which should not trigger the linter: ``` osmo_conv_encode(&gsm0503_tch_h24, &data[0], &cB[0]); osmo_conv_encode(&gsm0503_tch_h24, &data[72], &cB[228]); ``` PS2: Thanks a lot for the patch! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2551ffe2a0ebfd0a6df0e1d288a6f0af7e1eda7 Gerrit-Change-Number: 33641 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: tnt <[email protected]> Gerrit-Comment-Date: Fri, 07 Jul 2023 14:44:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: tnt <[email protected]> Gerrit-MessageType: comment
