Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33512 )
Change subject: ASCI: Add VTY to configure GCR (Group Call Register) ...................................................................... Patch Set 14: Code-Review+1 (2 comments) File src/libmsc/asci_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/8cd30416_22335d43 PS10, Line 219: "mute-talker", "Mute talker's downlink") > It should not be only for me testing the code, but also the users to test > their handsets. […] Done https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/50e3a041_fdbd9cb0 PS10, Line 340: if (gcr->mute_talker) : vty_out(vty, " mute-talker%s", VTY_NEWLINE); : else : vty_out(vty, " unmute-talker%s", VTY_NEWLINE); > here it looks like the mute/unmute really is a configurable property. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5bd034a62fc8b483f550d29103c2f7587198f590 Gerrit-Change-Number: 33512 Gerrit-PatchSet: 14 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:51:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
