Attention is currently required from: laforge, dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33511 )
Change subject: ASCI: Add call control for VGCS/VBS ...................................................................... Patch Set 12: (4 comments) File src/libmsc/msc_vgcs.c: https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/49ef700e_1ebf5345 PS12, Line 224: static uint8_t _rx_callref(uint8_t *ie, unsigned int remaining_len, uint32_t *callref, bool *with_prio, uint8_t *prio) > so the function returns uint8_t, but you are using "return _msg_too_short()", > which might retunr -EI […] Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/e1341d35_b9c7b377 PS12, Line 364: _rx_callref > return value could be negative Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/d4da5712_34963ffb PS12, Line 423: _rx_callref > negative return value Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/9d4bdba6_24b19228 PS12, Line 536: ie_len = _rx_callref(ie, remaining_len, callref, with_prio, prio); > negative return value Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Gerrit-Change-Number: 33511 Gerrit-PatchSet: 12 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Mon, 10 Jul 2023 09:03:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
