Attention is currently required from: pespin.

jolly has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/33603 )

Change subject: ASCI: Make bssmap_handle_ass_req_ct_speech() publically 
available.
......................................................................


Patch Set 2:

(1 comment)

File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/33603/comment/f3ab07c8_81de1a2a
PS2, Line 744: static int select_codecs(struct assignment_request *req, const 
struct gsm0808_channel_type *ct,
> why this change? bts can already be obtained through conn like before?
bssmap_handle_ass_req_ct_speech() is called by vgcs_fsm.c. At this point, there 
is no lchan assigned to the conn. This also means that there is no bts 
associated with the conn.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifc1e315d5282f01f8d1bd600d62476c2ae74eca9
Gerrit-Change-Number: 33603
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 10 Jul 2023 11:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to