Attention is currently required from: jolly.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/33602 )

Change subject: ASCI: Make function to add OSMUX IE public
......................................................................


Patch Set 3:

(1 comment)

File include/osmocom/bsc/assignment_fsm.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/33602/comment/968e8953_2718fa56
PS3, Line 43: gsm0808_extend_osmux
we don't usually have non-static (exported) symbol names that might clash with 
the prefixes used by libosmo*.  This is certainly the case with osmo_ prefix, 
but I think it equally applies to other prefixes that are commonly used by our 
libraries.

The rationale is that we might later have a library function by that name, and 
it would create symbol clashes if that ever happened.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33602
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1452cabb142f9e7a169f4ddfeac85908abaf8dfc
Gerrit-Change-Number: 33602
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Mon, 10 Jul 2023 18:20:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to