Attention is currently required from: fixeria, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33633 )
Change subject: S1AP_Templates: fix tr_S1AP_SetupReq ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33633/comment/fdf8336a_e7bd1d57 PS1, Line 72: }, *, { > ... but this IE is defined as optional, so `?` is not the correct option. […] ah, it's optional, of course. So we must use *. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4b52921053884e79349301598b75c264b7f058c Gerrit-Change-Number: 33633 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Mon, 10 Jul 2023 18:35:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
