Attention is currently required from: laforge.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/32727 )

Change subject: osmo-bts-trx: implement CSD scheduling support
......................................................................


Patch Set 14:

(1 comment)

File include/osmo-bts/scheduler.h:

https://gerrit.osmocom.org/c/osmo-bts/+/32727/comment/26899e4d_9098daae
PS4, Line 134:          struct l1sched_me
> I'm wondering why we need those at size 22. […]
This is needed in order to have proper measurements attached to `L1SAP 
TRAFFIC.ind` primitive. For each received block we average RSSI / ToA / CIR 
measurements of each burst carrying its bits. The L1SAP then averages these 
per-block measurements over SACCH multiframe periods. Given that we decode CSD 
frames with the same rate as speech frames (each 4th burst), there should not 
be a problem.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32727
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I08ffbf8e79ce76a586d61f5463890c6e72a6d9b9
Gerrit-Change-Number: 32727
Gerrit-PatchSet: 14
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Mon, 10 Jul 2023 22:12:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to