Attention is currently required from: laforge, lynxis lazus.
Hello Jenkins Builder, fixeria, lynxis lazus,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/33660
to look at the new patch set (#2).
Change subject: TLV_IE_Collection: use snake-style names during from_dict()
......................................................................
TLV_IE_Collection: use snake-style names during from_dict()
The TLV_IE_Collection, just like the individual TLV classes, do
use their snake-style names when converting from binary to dict
using the to_dict() method. It is inconsistent (and a bug) to
expect the CamelCase names during encoding (from_dict). After all,
we want the output of to_dict() to be used as input to from_dict().
Change-Id: Iabd1ad98c3878659d123eef919c22ca824886f8a
---
M pySim/ara_m.py
M pySim/global_platform.py
M pySim/tlv.py
3 files changed, 28 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/33660/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33660
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iabd1ad98c3878659d123eef919c22ca824886f8a
Gerrit-Change-Number: 33660
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-MessageType: newpatchset
