Patch Set 1: Hi Max,
> That's really huge. Could you perhaps split it into several smaller > commits with more detailed description? This would be much easier > to review and merge. agree with you, but as indicated here: http://lists.osmocom.org/pipermail/baseband-devel/2017-December/005464.html > The person who was working with us on the handover > code had left and we were not in the position to > upload the code at that time. So, I think this patch will remain unchanged until somebody with strong interest in handover will come and clean up / split the code. For now, it makes sense to cherry-pick this change into a separate branch as is. What do you think? -- To view, visit https://gerrit.osmocom.org/5490 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib01460b796d2107c4599d327e184eb42340999d2 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Muhammad Awais Aslam <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-HasComments: No
