Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33644 )
Change subject: sccp: Use tdef to implement osmo_sccp_timers ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/sccp_user.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/33644/comment/278a1b6c_8b86071b PS3, Line 241: talloc_size Not critical: you could use `talloc_memdup()`, which is equivalent to calling `talloc_size()` and `memcpy()`: ``` inst->tdefs = talloc_memdup(inst, osmo_sccp_timer_defaults, sizeof(osmo_sccp_timer_defaults)); ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I1dbe49a83a1bcddf074d5e638babd065834a0ebd Gerrit-Change-Number: 33644 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 12:22:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
