Attention is currently required from: osmith.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/33681 )

Change subject: configure: add --enable-meas-udp2db/pcap2db/vis
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4:
Do we really want to change the default behavior, which can be described as 
`[default=check]`? IMO, it's fine to build additional tools if the needed 
dependencies are available and skip building them if not. My suggestion is to 
require these libs only if `--enable-foo` is set to `yes` and skip building 
them if explicitly set to `no` or set to `check`, but libs are missing.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33681
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8b3d5efb769437a5d3036e1e627b8d477275d93e
Gerrit-Change-Number: 33681
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Tue, 11 Jul 2023 13:26:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to