Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/5535/1/src/gprs_coding_scheme.h File src/gprs_coding_scheme.h: Line 94: uint8_t sizeUL() const; I don't understand what we gain by all those conversions? What's the benefit? I can only see the problem of creating more clashes with other patches :/ -- To view, visit https://gerrit.osmocom.org/5535 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If599a6c8a6ef56d847604fcf41bb71decccd8a78 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
