Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/33706 )

Change subject: trxcon/l1sched: fix handling of UL FACCH on TCH/A[FH]S
......................................................................


Patch Set 1:

(2 comments)

File src/host/trxcon/src/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/33706/comment/ca13c8ff_21f14616
PS1, Line 255:                  data_len -= 2;
why not using sizeof(struct amr_hdr) as the comment indicates?


File src/host/trxcon/src/sched_lchan_tchh.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/33706/comment/f649cddb_1c64c617
PS1, Line 468:                  data_len -= 2;
same



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33706
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie217bbb389b5abb95d241781ffe3f5c7b1c188c0
Gerrit-Change-Number: 33706
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jul 2023 11:33:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to