Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33715 )
Change subject: MME_Tests: add Gn interface ...................................................................... Patch Set 1: (1 comment) File mme/MME_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33715/comment/b5e65cb9_99b22a1b PS1, Line 602: f_gtp_register_teid('00000000'O); This looks strange. TEID 0 is special and I would expect it's not needed to register it. In fact, it should be broadcasted to all the GTP ports registered imho. We can also leave it this way and reigster it explicitly on the requested handler. But better check the internals to make sure TEID is not already handled specially. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I38b668df15b3dd10542b4aa8790b9ea33c1f9635 Gerrit-Change-Number: 33715 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Wed, 12 Jul 2023 11:48:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
