Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33703 )
Change subject: osmo-bts-trx: pull the AMR header in tch_dl_dequeue() ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/33703/comment/c7c1442a_30b22b90 PS2, Line 406: msg_tch->l2h += sizeof(struct amr_hdr); > maybe assert that len > sizeof(struct amr_hdr). `osmo_amr_rtp_dec()` ensures that msgb has enough data in it, not only `struct amr_hdr` but also as much payload bytes as needed for the indicated `AMR FT`. So this is not really needed, we return early above if msgb is incomplete. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I15318e497b236128f779769e4fa99f307ea431ea Gerrit-Change-Number: 33703 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 12 Jul 2023 12:07:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
