Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33693 )
Change subject: create pySim.legacy.ts_51_011.py and move legacy code there ...................................................................... Patch Set 3: (1 comment) File pySim/legacy/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/33693/comment/7f7b3e9f_ad5794ba PS3, Line 7: """ Various constants from 3GPP TS 51.011 used by *legacy* code only. > I don't have a strong opinion here, but the fact that these definitions are > used by legacy code only […] the point is that nobody should use those incomplete data types here anymore. They do not reflect the hierarchical nature of the filesystem, but put all kinds of DFs in a flat dict. Likewise, they are certainly ages behind 3GPP specs. New code should make use of the pySim.filesystem class hierarchy to navigate the filesystem, select files, etc. It's never a good idea to have information duplicated in several locations in one code base. I would actually love to delete all this code, but there are still tons of users of the equally crufty pySim-prog. Eventually I might spend time re-implementing a saner version of pySim-prog not using any of the definitions here, but time/availability is of course a constraint. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20ceea3fdb02ee70d8c8889c078b2e5a0f17c83b Gerrit-Change-Number: 33693 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 12 Jul 2023 18:50:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
