Attention is currently required from: jolly. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33504 )
Change subject: ASCI: Add function to receive VGCS/VBS messages from BSS ...................................................................... Patch Set 14: (2 comments) File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/33504/comment/e38abce0_8f331f33 PS14, Line 396: so below, there is a priority: 1.msc_role 2.vgcs.bss 3.vgcs.cell. When there is an active vgcs.bss connection, is it possible that something also adds an msc_role to the same conn, and then that hides the active VGCS from incoming messages, because msc_role outranks vgcs.bss? I'm asking, because there are mechanisms where a subscriber re-uses an existing connection. For example, if some CM Service is already active (say USSD) and then also a call starts, then it opens another transaction on the same conn. Also a Call Re-Establishment does some more aggressive re-using of transactions and conns. Can this kind of thing happen at all, e.g. the active talker person happens to receive an SMS at the same time, and while the SMS is handled, an important VGCS message is lost? https://gerrit.osmocom.org/c/osmo-msc/+/33504/comment/f5bd4f59_ff26aa55 PS14, Line 413: return (now redundant) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie4a2f19ba75140a6f2de02b709597239c01f02a2 Gerrit-Change-Number: 33504 Gerrit-PatchSet: 14 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Thu, 13 Jul 2023 00:51:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
